Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19750/1/README.md File README.md: http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@9 PS1, Line 9: Other platforms might also be supported but are not well tested. To set up the > Could you wrap this line and L19 to keep the 90 char limit? Done. Thank Michael's explanation! http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63 PS1, Line 63: > No need to set CXX? I'm not sure.. TBO, I haven't made the whole toolchain build succeeded on my MacBook. I just played and built some components (trying to set up CLion on MacOS). This command is the one that can build some components but will still fail at last.. -- To view, visit http://gerrit.cloudera.org:8080/19750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4 Gerrit-Change-Number: 19750 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 18 Apr 2023 09:07:58 +0000 Gerrit-HasComments: Yes
