Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py ...................................................................... IMPALA-11974: Fix xrange, split in collect_diagnostics.py Python3 deprecates xrange operator, this commit replaces it with the range operator similar to earlier replacements in IMPALA-11974. Adds universal_newlines to Popen so that we return text in Python 3. Testing: - Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid> --minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps --stacks 2 1' with Python 2/3 and inspected the results. Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4 Reviewed-on: http://gerrit.cloudera.org:8080/19746 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M bin/diagnostics/collect_diagnostics.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4 Gerrit-Change-Number: 19746 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]>
