Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 )
Change subject: IMPALA-11253: Support testing with Java 11 ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/19539/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/19539/3/bin/impala-config.sh@421 PS3, Line 421: DETECTED_JAVA_HOME="${JVMS_PATH}/java-${IMPALA_JDK_VERSION}-openjdk-${UBUNTU_PACKAGE_ARCH}" line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19539/3/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/19539/3/bin/start-impala-cluster.py@217 PS3, Line 217: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/19539/3/bin/start-impala-cluster.py@217 PS3, Line 217: flake8: E201 whitespace after '[' http://gerrit.cloudera.org:8080/#/c/19539/3/bin/start-impala-cluster.py@231 PS3, Line 231: n flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19539/3/bin/start-impala-cluster.py@234 PS3, Line 234: M flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19539/3/testdata/bin/run-ranger-server.sh File testdata/bin/run-ranger-server.sh: http://gerrit.cloudera.org:8080/#/c/19539/3/testdata/bin/run-ranger-server.sh@34 PS3, Line 34: JAVA_OPTS="-XX:+IgnoreUnrecognizedVMOptions -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=30130" \ line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/19539/3/tests/verifiers/test_banned_log_messages.py File tests/verifiers/test_banned_log_messages.py: http://gerrit.cloudera.org:8080/#/c/19539/3/tests/verifiers/test_banned_log_messages.py@24 PS3, Line 24: class TestBannedLogMessages(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/19539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a Gerrit-Change-Number: 19539 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 23:50:22 +0000 Gerrit-HasComments: Yes
