Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 )
Change subject: IMPALA-11253: Support testing with Java 11 ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/19539/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19539/1//COMMIT_MSG@28 PS1, Line 28: InaccessibleObjectException is not present in impalad logs. Tested with : > Since we are producing Java 8 compatible jars, then we can say that the doc Done: https://issues.apache.org/jira/browse/IMPALA-12081 http://gerrit.cloudera.org:8080/#/c/19539/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19539/2//COMMIT_MSG@30 PS2, Line 30: JDBC_TEST=false CLUSTER_TEST=false FE_TEST=false BE_TEST=false \ : EE_TEST_FILES=observability/test_log_fragments.py run-all-tests.sh > I remember one of the frontend tests failing due to a difference in the JMX I don't understand what you're suggesting here. http://gerrit.cloudera.org:8080/#/c/19539/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/19539/2/bin/impala-config.sh@454 PS2, Line 454: > Tiny nit: If we switch to '[0-9]\+\.[0-9]\+\.[0-9]\+', that requires at lea Done http://gerrit.cloudera.org:8080/#/c/19539/2/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/19539/2/bin/start-impala-cluster.py@216 PS2, Line 216: if int(os.environ["IMPALA_JDK_VERSION"]) >= 9: : JAVA11_BASE_OPENS= [ "java.io", "java.lang.module", "java.lang.ref", "java.lang", : "java.net", "java.nio.charset", "java.nio.file.attribute", : "java.nio", "java.security", "java.util.concurrent", : "java.util.jar", "java.util.zip", "java.util", : "jdk.internal.loader", "jdk.internal.math", : "jdk.internal.module", "jdk.internal.ref", : "jdk.internal.reflect", "jdk.internal.util.jar", "sun.nio.fs"] : for base_open in JAVA11_BASE_OPENS: : java_tool_options += " --add-opens=java.base/{0}=ALL-UNNAMED".format(base_open) : : JAVA11_DYNALINK_OPENS = ["jdk.dynalink.beans", "jdk.dynalink.linker.support", : "jdk.dynalink.linker", "jdk.dynalink.support", : "jdk.dynalink"] : for dynalink_open in JAVA11_DYNALINK_OPENS: : java_tool_options += " --add-opens=jdk.dynalink/{0}=ALL-UNNAMED".format(dynalink_open) : : java_tool_options += " --add-opens=jdk.management.jfr/jdk.management.jfr=ALL-UNNAMED" : java_tool_options += " --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED" > We had talked about having the C++ binary do this check itself? Is that sti I was planning to address that in https://issues.apache.org/jira/browse/IMPALA-11260. But I could figure it out as part of this ticket. http://gerrit.cloudera.org:8080/#/c/19539/2/java/TableFlattener/pom.xml File java/TableFlattener/pom.xml: http://gerrit.cloudera.org:8080/#/c/19539/2/java/TableFlattener/pom.xml@37 PS2, Line 37: 3.11.0 > Nit: Version 3.11 came out sometime recently. Doesn't look like it has much Done http://gerrit.cloudera.org:8080/#/c/19539/2/java/datagenerator/pom.xml File java/datagenerator/pom.xml: http://gerrit.cloudera.org:8080/#/c/19539/2/java/datagenerator/pom.xml@94 PS2, Line 94: 3.0.0</v > Nit: Doesn't matter, but 3.0.0 is out now. Done http://gerrit.cloudera.org:8080/#/c/19539/2/java/executor-deps/pom.xml File java/executor-deps/pom.xml: http://gerrit.cloudera.org:8080/#/c/19539/2/java/executor-deps/pom.xml@191 PS2, Line 191: 3.5.0 > Nit: 3.5.0 is out now Done http://gerrit.cloudera.org:8080/#/c/19539/2/java/shaded-deps/hive-exec/pom.xml File java/shaded-deps/hive-exec/pom.xml: http://gerrit.cloudera.org:8080/#/c/19539/2/java/shaded-deps/hive-exec/pom.xml@58 PS2, Line 58: 3.4.1 > Nit: Looks like 3.4.1 is out now Done http://gerrit.cloudera.org:8080/#/c/19539/2/tests/verifiers/test_omit_logs.py File tests/verifiers/test_omit_logs.py: http://gerrit.cloudera.org:8080/#/c/19539/2/tests/verifiers/test_omit_logs.py@24 PS2, Line 24: > Nit: For naming, I would lean towards something like TestBannedLogMessages Done http://gerrit.cloudera.org:8080/#/c/19539/2/tests/verifiers/test_omit_logs.py@33 PS2, Line 33: : > Let's also check catalogd. Done -- To view, visit http://gerrit.cloudera.org:8080/19539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a Gerrit-Change-Number: 19539 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 23:49:33 +0000 Gerrit-HasComments: Yes
