Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 )
Change subject: IMPALA-12091: Control scan parallelism by its processing cost ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19807/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19807/1//COMMIT_MSG@18 PS1, Line 18: NUM_SCANNER_THREADS Should create new query option for this specific purpose rather than reuse NUM_SCANNER_THREADS. http://gerrit.cloudera.org:8080/#/c/19807/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/19807/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java@a1036 PS1, Line 1036: I need to look around if there is another reference to MT_DOP like this in frontend code. They should be replaced with analyzer.getMaxParallelismPerNode(). Backend code should get checked as well. -- To view, visit http://gerrit.cloudera.org:8080/19807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If948e45455275d9a61a6cd5d6a30a8b98a7c729a Gerrit-Change-Number: 19807 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 21:06:11 +0000 Gerrit-HasComments: Yes
