Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 )
Change subject: IMPALA-12091: Control scan parallelism by its processing cost ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19807/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19807/1//COMMIT_MSG@18 PS1, Line 18: > Should create new query option for this specific purpose rather than reuse Added PROCESSING_COST_MAX_THREADS. http://gerrit.cloudera.org:8080/#/c/19807/2/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/19807/2/be/src/exec/exec-node.cc@93 PS2, Line 93: effective_dop_ = state->query_options().mt_dop > 0; This should just be effective_dop_ = state->query_options().mt_dop; http://gerrit.cloudera.org:8080/#/c/19807/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/19807/1/be/src/scheduling/scheduler.cc@441 PS1, Line 441: a) Map scan ranges to > I think this is a bug here. Submitted IMPALA-12106 to fix this separately. Patch set 2 has overlap with IMPALA-12106. http://gerrit.cloudera.org:8080/#/c/19807/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/19807/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java@a1036 PS1, Line 1036: > I need to look around if there is another reference to MT_DOP like this in Checked all references to MT_DOP in both frontend and backend code. Replaced them as necessary. -- To view, visit http://gerrit.cloudera.org:8080/19807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If948e45455275d9a61a6cd5d6a30a8b98a7c729a Gerrit-Change-Number: 19807 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 01 May 2023 04:59:33 +0000 Gerrit-HasComments: Yes
