Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19829 )

Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Looks good, thanks.

http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc
File be/src/benchmarks/date-benchmark.cc:

http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc@244
PS2, Line 244: ;
Nit: superfluous semicolon.



--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 03 May 2023 08:51:17 +0000
Gerrit-HasComments: Yes

Reply via email to