Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@23 PS2, Line 23: DateValue > nit: typo Done http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@26 PS2, Line 26: cast(l_shipdate as date) > This is a STRING to DATE conversion while the title says the other directio HS2 returns DATE (and TIMESTAMP + DECIMAL) as string, so the cast above is followed by a DateValue->std::string conversion. Before that patch the bulk of the time came for the second conversion. Added a note about this. -- To view, visit http://gerrit.cloudera.org:8080/19829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4 Gerrit-Change-Number: 19829 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 03 May 2023 14:47:32 +0000 Gerrit-HasComments: Yes
