Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19837 )
Change subject: IMPALA-11880: Adds support for authenticating to Impala using JWTs. This support was modeled after the LDAP authentication. ...................................................................... Patch Set 2: (3 comments) Found a couple of nits, nothing serious http://gerrit.cloudera.org:8080/#/c/19837/2/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/19837/2/shell/option_parser.py@275 PS2, Line 275: to retrieve the LDAP password help text still refers to LDAP (copy-paste bug) http://gerrit.cloudera.org:8080/#/c/19837/2/tests/shell/test_shell_commandline_jwt_auth.py File tests/shell/test_shell_commandline_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/19837/2/tests/shell/test_shell_commandline_jwt_auth.py@95 PS2, Line 95: e nit: typo http://gerrit.cloudera.org:8080/#/c/19837/2/tests/shell/test_shell_commandline_jwt_auth.py@101 PS2, Line 101: e nit: typo -- To view, visit http://gerrit.cloudera.org:8080/19837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52247f9262c548946269fe5358b549a3e8c86d4c Gerrit-Change-Number: 19837 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Wed, 03 May 2023 20:20:33 +0000 Gerrit-HasComments: Yes
