Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19837 )
Change subject: IMPALA-11880: Adds support for authenticating to Impala using JWTs. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/19837/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19837/5//COMMIT_MSG@11 PS5, Line 11: If JWT authentication is used, the Impala shell enforces the use of the hs2-http protocol > nit: break the long lines - not exceeding the yellow dotted line. Done http://gerrit.cloudera.org:8080/#/c/19837/5//COMMIT_MSG@26 PS5, Line 26: > Add a "Testing" section for the testing done for the patch. Done http://gerrit.cloudera.org:8080/#/c/19837/5/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/19837/5/shell/option_parser.py@233 PS5, Line 233: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/19837/5/testdata/bin/jwt-util.py File testdata/bin/jwt-util.py: http://gerrit.cloudera.org:8080/#/c/19837/5/testdata/bin/jwt-util.py@122 PS5, Line 122: key_invalid_jwk > A little confusion for the variable name. The jwk key itself is a valid key Agreed. That name never sat well with me, but I couldn't come up with anything better, until today that is. I renamed the variables with the word "untrusted" in them to reflect that the JWK/JWT are valid but will not be trusted. http://gerrit.cloudera.org:8080/#/c/19837/5/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/19837/5/tests/custom_cluster/test_shell_jwt_auth.py@33 PS5, Line 33: Impala server logs > except log file, could we verify http metrics of "total-jwt-token-auth-succ good idea, added -- To view, visit http://gerrit.cloudera.org:8080/19837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52247f9262c548946269fe5358b549a3e8c86d4c Gerrit-Change-Number: 19837 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 09 May 2023 21:42:03 +0000 Gerrit-HasComments: Yes
