Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19829/5/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/19829/5/be/src/runtime/raw-value.cc@113 PS5, Line 113: tmp.assign(string_val->ptr, string_val->len); tmp should have block scope here. -- To view, visit http://gerrit.cloudera.org:8080/19829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4 Gerrit-Change-Number: 19829 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 17:21:44 +0000 Gerrit-HasComments: Yes
