Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 )
Change subject: IMPALA-11253: Support testing with Java 11 ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/19539/9/tests/verifiers/test_banned_log_messages.py File tests/verifiers/test_banned_log_messages.py: http://gerrit.cloudera.org:8080/#/c/19539/9/tests/verifiers/test_banned_log_messages.py@35 PS9, Line 35: "INFO", "InaccessibleObjectException", expected_count=0) This only verifies the latest log file, i.e. the one linked by impalad.INFO. https://github.com/apache/impala/blob/9fb1274867a59b467617e6292a54fd1f0bb937ad/tests/common/impala_test_suite.py#L1265-L1267 For e2e tests, there will be several log files. It'd be better to verify all of them. Maybe using a 'grep' command on the log folder recursively is simpler. BTW, have we verified that this fails when removing the add-opens JVM options? -- To view, visit http://gerrit.cloudera.org:8080/19539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a Gerrit-Change-Number: 19539 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 02:55:12 +0000 Gerrit-HasComments: Yes
