Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 )
Change subject: IMPALA-11253: Support testing with Java 11 ...................................................................... Patch Set 10: (1 comment) This is looking good to me. One small nit about the verification test. http://gerrit.cloudera.org:8080/#/c/19539/10/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/19539/10/bin/run-all-tests.sh@329 PS10, Line 329: ${CLUSTER_TEST_VERIFIERS} Should we do this as a separate step not tied to custom cluster tests? In our upstream precommit, we run multiple jobs. One job does be tests + fe tests. Another job does ee tests + custom cluster tests. Another job does dockerised tests. I think we could cover them all by splitting this off from custom clusters and adding it with its own pytest invocation below. -- To view, visit http://gerrit.cloudera.org:8080/19539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a Gerrit-Change-Number: 19539 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 00:05:34 +0000 Gerrit-HasComments: Yes
