Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 )
Change subject: IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc@310 PS3, Line 310: "--add-opens=java.base/java.io=ALL-UNNAMED", > I'm confused why we want to hard-code these in C++ codes. If the motivation We aren't worried about passing JAVA_TOOL_OPTIONS through to the shell commands. The thought was that impala could detect the Java version at startup and set add-opens as needed. That avoids needing to detect the Java version and set the add-opens in various test scripts (bin/start-impala-cluster.py), docker entrypoint scripts, and any other place that invokes an Impala binary. I imagine some users run Impala without docker images (which have the detection logic), and I don't think they would know to set these options. It turns out Java 8 ignores add-opens, so this is currently not conditional. We don't know if the list of add-opens will need to vary by the Java version. Maybe it would be useful to have a way to turn this off. -- To view, visit http://gerrit.cloudera.org:8080/19845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8 Gerrit-Change-Number: 19845 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 04:58:11 +0000 Gerrit-HasComments: Yes
