Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 )
Change subject: PROTOTYPE IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc@310 PS3, Line 310: "--add-opens=java.base/java.io=ALL-UNNAMED", > Java must be doing something special for JAVA_TOOL_OPTIONS. Maybe it is con We could validate that the add-opens are present using code similar to what we do here: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/common/JniUtil.java#L376-L377 -- To view, visit http://gerrit.cloudera.org:8080/19845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8 Gerrit-Change-Number: 19845 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 03:01:33 +0000 Gerrit-HasComments: Yes
