Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19898 )
Change subject: IMPALA-10186: Fix writing empty parquet page ...................................................................... Patch Set 1: (2 comments) Thanks for fixing this issue, Michael. Based on your investigation the following statements reproduce the bug: set PARQUET_PAGE_ROW_COUNT_LIMIT=20000; create table empty_parquet_page stored as parquet as select distinct l_orderkey as n from tpch_parquet.lineitem order by l_orderkey limit 41000; Could you please add an e2e for this? test_parquet_page_index.py is a good place for this and has examples about verifying the Page index. http://gerrit.cloudera.org:8080/#/c/19898/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19898/1//COMMIT_MSG@9 PS1, Line 9: Fixeus nit: Fixes http://gerrit.cloudera.org:8080/#/c/19898/1/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: http://gerrit.cloudera.org:8080/#/c/19898/1/be/src/util/dict-encoding.h@206 PS1, Line 206: inline nit: inline keyword is redundant here, see: https://en.cppreference.com/w/cpp/language/inline "A function defined entirely inside a class/struct/union definition, whether it's a member function or a non-member friend function, is implicitly an inline function unless it is attached to a named module (since C++20)." -- To view, visit http://gerrit.cloudera.org:8080/19898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90d30d958f07c6289a1beba1b5df1ab3d7213799 Gerrit-Change-Number: 19898 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 09:58:27 +0000 Gerrit-HasComments: Yes
