Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19898 )
Change subject: IMPALA-10186: Fix writing empty parquet page ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19898/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/19898/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc@537 PS3, Line 537: // Shouldn't happen on an empty page as it should be sized for bytes_needed. > A dcheck could be added for current_page_->header.uncompressed_page_size == Done http://gerrit.cloudera.org:8080/#/c/19898/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc@928 PS3, Line 928: easons - because the current page is not bi > after the patch we try again only once Done http://gerrit.cloudera.org:8080/#/c/19898/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc@946 PS3, Line 946: } > Can you add a comment about this being a second try and that it needs to su Done http://gerrit.cloudera.org:8080/#/c/19898/3/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/19898/3/testdata/datasets/functional/functional_schema_template.sql@4160 PS3, Line 4160: ==== > a name like empty_parquet_page_source and a comment with the Jira number co Done -- To view, visit http://gerrit.cloudera.org:8080/19898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90d30d958f07c6289a1beba1b5df1ab3d7213799 Gerrit-Change-Number: 19898 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 16:27:56 +0000 Gerrit-HasComments: Yes
