Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19818
to look at the new patch set (#2).
Change subject: IMPALA-12059: Filter out harmless warnings from Thrift
compilation
......................................................................
IMPALA-12059: Filter out harmless warnings from Thrift compilation
This wraps Thrift compilation commands with the
bin/thrift-quiet-wrapper.sh shell script. This script runs the
Thrift compilation command while filtering out warnings
that we have no intention of fixing (e.g. warnings about
using 'binary' rather than 'list<byte>', etc).
This filters all warnings from hive_metastore.thrift, because
it is not under Impala control and generates a large number of
warnings.
When Thrift compilation fails, Thrift outputs messages with
"ERROR:" and "FAILURE:" and these are never filtered.
Testing:
- Ran "make gen-deps" on a clean build and verified that
the Thrift warnings are filtered
- Modified a Thrift file and verified errors are not
filtered
Change-Id: I7b912ac3d57d1a51e957889b5798dc05d156a3d0
---
A bin/thrift-quiet-wrapper.sh
M common/thrift/CMakeLists.txt
2 files changed, 57 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/19818/2
--
To view, visit http://gerrit.cloudera.org:8080/19818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b912ac3d57d1a51e957889b5798dc05d156a3d0
Gerrit-Change-Number: 19818
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
