Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19818 )
Change subject: IMPALA-12059: Filter out harmless warnings from Thrift compilation ...................................................................... Patch Set 2: > Thanks for cleaning these up! > > Just have two questions: > Are there compilation options in thrift compilers to ignore these > warnings? > Can we deduplicate the warnings instead of ignoring them? There is an option to turn off all warnings, but I think we still care about warnings that are new. There is an option to disable the warning for 64-bit constants, and we could do that. There aren't equivalent flags for the other warnings we see. We could get stricter about new warnings from our thrift files by generating an error if there are unexpected warnings. There is some deduplication that can be done within a single Thrift invocation, but it is not possible to deduplicate across the different Thrift invocations (which happen for each .thrift file). Part of the problem is that our CMake code is doing recursive generation, so some frequently used Thrift files generate warnings on each different invocation. That can be reworked, but it is a bigger change. >From my point of view, the warnings from our Thrift files have been there for >years. I don't think we plan on fixing any of them, so I would rather filter >them out than deduplicate them. hive_metastore.thrift is a complicated case and I'm not sure what we should do. I think that is better addressed on the Hive side by failing Thrift generation if there are unexpected warnings (or adding some unit test that does the same check). -- To view, visit http://gerrit.cloudera.org:8080/19818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b912ac3d57d1a51e957889b5798dc05d156a3d0 Gerrit-Change-Number: 19818 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 24 May 2023 20:06:19 +0000 Gerrit-HasComments: No
