Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 )
Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19838/2/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/19838/2/be/src/catalog/catalog-server.cc@136 PS2, Line 136: "to whitelist the table properties that are supposed t > HiveMetaStore doesn't allow transactional and transactional_properties to b About change of 'transactional': there is a test where it changes, though 'external' also changes in that case, so it is not need to look specifically for transactional: https://github.com/apache/impala/blob/dc63ae514a445e3f197cab405b01a30c58015695/testdata/workloads/functional-query/queries/QueryTest/acid.test#L49 I was also able to change transactional_properties in Hive from 'insert_only' to 'default' http://gerrit.cloudera.org:8080/#/c/19838/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/19838/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@377 PS4, Line 377: toLowerCase My impression is that table property names are also case sensitive: I was able to set a table property 'external', but and created a separate property from the default 'EXTERNAL'. So the 'external' in the flag and tests should be also all capital. (this was surprising to me, it absolutely doesn't make sense to me to use properties with only differences in case) -- To view, visit http://gerrit.cloudera.org:8080/19838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia66b96a7c4b7f50fbf46b2e02296cd29a47347b6 Gerrit-Change-Number: 19838 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 24 May 2023 07:13:44 +0000 Gerrit-HasComments: Yes
