Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 )
Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19838/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/19838/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@374 PS4, Line 374: whitelistedTblProperties_ Iceberg also use table property 'metadata_location' to denote the current snapshot file. If it changes we need to do a full table reload. http://gerrit.cloudera.org:8080/#/c/19838/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3936 PS4, Line 3936: if ((!beforeTable.getParameters().containsKey(whitelistConfig) && : afterTable.getParameters().containsKey(whitelistConfig)) || : (beforeTable.getParameters().containsKey(whitelistConfig) && : !afterTable.getParameters().containsKey(whitelistConfig)) || : (beforeTable.getParameters().containsKey(whitelistConfig) && : afterTable.getParameters().containsKey(whitelistConfig) && : !beforeTable.getParameters().get(whitelistConfig) : .equals(afterTable.getParameters().get(whitelistConfig)))) { : return true; Can it be replaced with: String cfgBefore = beforeTable.getParameters().get(whitelistConfig); String cfgAfter = afterTable.getParameters().get(whitelistConfig)); if (!Objects.equals(cfgBefore, cfgAfter)) return true; -- To view, visit http://gerrit.cloudera.org:8080/19838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia66b96a7c4b7f50fbf46b2e02296cd29a47347b6 Gerrit-Change-Number: 19838 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 May 2023 09:47:03 +0000 Gerrit-HasComments: Yes
