Minghui Zhu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 )
Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19768/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/19768/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1394 PS3, Line 1394: migrateOrCopyConjunctsToInlineView(analyzer, inlineViewRef, tids, analyticPreds); > 'unassignedConjuncts' is not updated after the refactor. In the previous pa I added a parameter evalPreds to indicate analyticPreds or unassignedConjunctions, so unassignedConjunctions is updated. And the logic here is a bit confusing, I refactor it again to make it clearer. http://gerrit.cloudera.org:8080/#/c/19768/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1425 PS3, Line 1425: analytic > nit: remove "analytic" here and in the next line Done -- To view, visit http://gerrit.cloudera.org:8080/19768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6c209b2a64bad37d893ba8b520342bf1f9a7513 Gerrit-Change-Number: 19768 Gerrit-PatchSet: 3 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Minghui Zhu <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 31 May 2023 10:20:13 +0000 Gerrit-HasComments: Yes
