Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19768 )

Change subject: IMPALA-12051: Propagate analytic tuple predicates of 
outer-joined InlineView
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

Thanks for the update!

Since I have some issues access my original GitHub account with Impala 
committer privilege, I can only +1 with this temporary account.

http://gerrit.cloudera.org:8080/#/c/19768/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19768/6//COMMIT_MSG@79
PS6, Line 79:
nit. Is it possible to copy a section of the bad plan for the above query to 
show the missing predicates?

Since this bug is quite severe, it is a good idea to show how to spot the bad 
plan in general.



--
To view, visit http://gerrit.cloudera.org:8080/19768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6c209b2a64bad37d893ba8b520342bf1f9a7513
Gerrit-Change-Number: 19768
Gerrit-PatchSet: 6
Gerrit-Owner: Minghui Zhu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Minghui Zhu <[email protected]>
Gerrit-Reviewer: Qifan Chen (767)
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Xianqing He <[email protected]>
Gerrit-Comment-Date: Thu, 01 Jun 2023 13:04:09 +0000
Gerrit-HasComments: Yes

Reply via email to