ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )
Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown ...................................................................... Patch Set 6: (2 comments) Thanks Quanlong! I got it. I just tested both cases: "=" and "between...and". http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@155 PS6, Line 155: if (e instanceof BinaryPredicate) { > What about other kinds of predicates? It seems not just BinaryPredicate can Ack http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@159 PS6, Line 159: if (rhs != null && !rhs.isMaterialized()) continue; > I understand that in this case, the slot is unmaterialized since we don't n Ack -- To view, visit http://gerrit.cloudera.org:8080/19937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f Gerrit-Change-Number: 19937 Gerrit-PatchSet: 6 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 31 May 2023 12:52:25 +0000 Gerrit-HasComments: Yes
