Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )
Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown ...................................................................... Patch Set 12: Code-Review+1 (2 comments) The new approach looks much better! http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1887 PS12, Line 1887: // same list should be marked as assigned. nit: please add the reason // If a constant FALSE conjunct is found, the other conjuncts in the // same list should be marked as assigned so they won't be considered anymore in predicate assignment. http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906 PS12, Line 1906: // list should be marked as assigned. nit: please add the same reason mentioned above -- To view, visit http://gerrit.cloudera.org:8080/19937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f Gerrit-Change-Number: 19937 Gerrit-PatchSet: 12 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 19 Jun 2023 00:37:42 +0000 Gerrit-HasComments: Yes
