Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 )
Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView ...................................................................... Patch Set 8: (1 comment) > Patch Set 8: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9370/ http://gerrit.cloudera.org:8080/#/c/19768/8/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: http://gerrit.cloudera.org:8080/#/c/19768/8/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@2241 PS8, Line 2241: ---- RESULTS The query string contains "order by" so the test verifier thought the results are sorted (but they are actually not). https://github.com/apache/impala/blob/3c49ebad6b1c55305064ef905ef78b242b024c1f/tests/common/test_result_verifier.py#L459 To workaround this issue of the test code, we can add a label of VERIFY_IS_EQUAL_SORTED on the RESULTS section, e.g. https://github.com/apache/impala/blob/3c49ebad6b1c55305064ef905ef78b242b024c1f/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test#L91 All these new tests need this label. -- To view, visit http://gerrit.cloudera.org:8080/19768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6c209b2a64bad37d893ba8b520342bf1f9a7513 Gerrit-Change-Number: 19768 Gerrit-PatchSet: 8 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Minghui Zhu <[email protected]> Gerrit-Reviewer: Qifan Chen (767) Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Sun, 04 Jun 2023 00:37:52 +0000 Gerrit-HasComments: Yes
