Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ ...................................................................... IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ Restricts jvm_automatic_add_opens to only apply to Java 9+ where the option exists. Previously it would also include it in Java 8, which caused the JVM to ignore all options in JAVA_TOOL_OPTIONS. Tests for Java version by running $JAVA_HOME/bin/java -version (or "java" if JAVA_HOME is unset) and parsing version from the first line. All JVM implementations are expected to include the version in a quoted string, such as "1.8.0_42" and "11.0.1". Also added add-opens flags for frontend tests. test_no_inaccessible_objects detected this in a test run. Testing: - manually confirmed -agentlib options are present with both Java 8 and Java 11. - promoted test_jvm_mem_tracking to run in all strategies, as it's fast and ensures JAVA_TOOL_OPTIONS is honored. Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Reviewed-on: http://gerrit.cloudera.org:8080/19939 Reviewed-by: Zoltan Borok-Nagy <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> Reviewed-by: Quanlong Huang <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/init.cc M bin/run-all-tests.sh M docker/daemon_entrypoint.sh M tests/custom_cluster/test_jvm_mem_tracking.py 4 files changed, 65 insertions(+), 8 deletions(-) Approvals: Zoltan Borok-Nagy: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, but someone else must approve Quanlong Huang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
