Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )
Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19939/4/be/src/common/init.cc@313 PS4, Line 313: string cmd = "java"; > Other reviewers can chime in here. I can live with the unconditional approa Reverted. http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh@276 PS4, Line 276: JAVA_OPTIONS+=" --add-opens=jdk.management.jfr/jdk.management.jfr=ALL-UNNAMED" > Yeah, that would make sense. Done -- To view, visit http://gerrit.cloudera.org:8080/19939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf Gerrit-Change-Number: 19939 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Jun 2023 20:38:42 +0000 Gerrit-HasComments: Yes
