Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19818 )
Change subject: IMPALA-12059: Deduplicate and filter warnings from Thrift compilation ...................................................................... Patch Set 3: Code-Review+1 (1 comment) LGTM. Just have a minor comment. http://gerrit.cloudera.org:8080/#/c/19818/3/bin/thrift-quiet-wrapper.sh File bin/thrift-quiet-wrapper.sh: http://gerrit.cloudera.org:8080/#/c/19818/3/bin/thrift-quiet-wrapper.sh@54 PS3, Line 54: Should we remove the temp file? -- To view, visit http://gerrit.cloudera.org:8080/19818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b912ac3d57d1a51e957889b5798dc05d156a3d0 Gerrit-Change-Number: 19818 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 13:19:29 +0000 Gerrit-HasComments: Yes
