Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19926 )
Change subject: IMPALA-6665: Tag CatalogOp logs with query ids ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19926/2/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: http://gerrit.cloudera.org:8080/#/c/19926/2/be/src/catalog/catalog.cc@187 PS2, Line 187: TGetFunctionsRequest > nit: TGetFunctionsRequest and TGetCatalogObjectRequest also has a TCatalogS They are not used in queries: TGetFunctionsRequest seems stale. I found it's only used in test_catalog_service_client.py: https://github.com/apache/impala/blob/4cf0bfa83f9641eb95d83c76af7962e6a3f1e064/tests/catalog_service/test_catalog_service_client.py#L73 Note that the SHOW FUNCTIONS statement is served by the local catalog cache of coordinator so no need for this RPC. TGetCatalogObjectRequest is not used so also stale now. Coordinator uses its local catalog to serve the /catalog_object webUI. I think we can consider removing these RPCs in a separate JIRA. -- To view, visit http://gerrit.cloudera.org:8080/19926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90933433e23a171993de3c1ee355d776a53eda66 Gerrit-Change-Number: 19926 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 12:59:20 +0000 Gerrit-HasComments: Yes
