Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19926 )
Change subject: IMPALA-6665: Tag CatalogOp logs with query ids ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19926/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19926/2//COMMIT_MSG@12 PS2, Line 12: of the thread executing the RPC. > This appears to be using an existing mechanism for the actual logging. Plea Yeah, the mechanism is added in IMPALA-6664. All logging levels are affected. https://github.com/apache/impala/blob/c75e8b28e6246a4a1e131b66b4d3dc74774d62fd/be/src/common/logging.cc#L61-L81 https://github.com/apache/impala/blob/c75e8b28e6246a4a1e131b66b4d3dc74774d62fd/be/src/common/logging.cc#L237 http://gerrit.cloudera.org:8080/#/c/19926/2//COMMIT_MSG@18 PS2, Line 18: Here is an example of a CTAS command. It actually contains two RPCs, > Please confirm that the ] brackets are correct in the example. Seems strang Yeah, it's expected. The part of "filename:line] " is added by glog: https://github.com/google/glog/blob/v0.3.5/src/logging.cc#L1239-L1253 It's intended to follow the convention in glog so we used "queryId] ": https://github.com/apache/impala/blob/c75e8b28e6246a4a1e131b66b4d3dc74774d62fd/be/src/common/logging.cc#L66 Note that such a log format has been used for years. It's not changed by this patch. -- To view, visit http://gerrit.cloudera.org:8080/19926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90933433e23a171993de3c1ee355d776a53eda66 Gerrit-Change-Number: 19926 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Jun 2023 02:26:09 +0000 Gerrit-HasComments: Yes
