Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 )
Change subject: [DO-NOT-MERGE] Experimental link time optimization ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18131/3/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: http://gerrit.cloudera.org:8080/#/c/18131/3/cmake_modules/kudu_cmake_fns.txt@23 PS3, Line 23: cmake_minimum_required(VERSION 3.8) This prevents -flto on gutil. We compile gutil headers with both unsigned-char and signed-char, which violate the C++ One Definition Rule across the module. Can also be accomplished by disabling INTERPROCEDURAL_OPTIMIZATION for just the gutil library. -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 23:01:20 +0000 Gerrit-HasComments: Yes
