Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18131 )
Change subject: [DO-NOT-MERGE] Experimental link time optimization ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18131/3/be/CMakeLists.txt@28 PS3, Line 28: SET(CMAKE_INTERPROCEDURAL_OPTIMIZATION ON) > We probably want to be more targeted about this. We don't want to bother fo Trying to be more targeted about it doesn't seem to work. Best case is only enable it for release builds (and have a way to enable it for debug builds if we need to debug an LTO-specific issue). -- To view, visit http://gerrit.cloudera.org:8080/18131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4f822a1249fde0a48e31d5c8f7f5952315f470 Gerrit-Change-Number: 18131 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 23:09:00 +0000 Gerrit-HasComments: Yes
