Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 )
Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20020/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20020/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6628 PS1, Line 6628: TblTransaction tblTxn = null; This is an improvement compared to the previous situation, but I think that it would be even better if we would hold less locks while doing this RPC. Moving the TblTransaction block after catalog_.getLock().writeLock().unlock() in line 6644 would avoid holding a global lock while doing an HMS RPC and seems safe as we don't need tblTxn before that point. -- To view, visit http://gerrit.cloudera.org:8080/20020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a64764d0568fc1e6c6f4c52f9e220df3130bd84 Gerrit-Change-Number: 20020 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 07 Jun 2023 08:19:36 +0000 Gerrit-HasComments: Yes
