Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20020 )
Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction ...................................................................... IMPALA-12189: updateCatalog should handle failures in createTblTransaction updateCatalog() invokes createTblTransaction() for transactional tables. It's called after acquiring the table lock. The write lock of catalog's versionLock will also be acquired by the current thread. Whenever we hit an exception, we should release those locks. This patch moves the code calling createTblTransaction() into the exception handling scope. Tests: - Add a debug action to abort the transaction in updateCatalog() so createTblTransaction() will fail. - Add e2e test for the error handling. Change-Id: I3a64764d0568fc1e6c6f4c52f9e220df3130bd84 Reviewed-on: http://gerrit.cloudera.org:8080/20020 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/DebugUtils.java M tests/query_test/test_acid.py 3 files changed, 53 insertions(+), 14 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3a64764d0568fc1e6c6f4c52f9e220df3130bd84 Gerrit-Change-Number: 20020 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
