[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/19776/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19776/11//COMMIT_MSG@28 PS11, Line 28: file_position, pos nit: maybe "file_path, position"? Why sorting by these two columns: DeleteData sorted by file_path and position can be found and loaded more easily without having to scan more files, improving query performance and subsequent compaction of datafile and deletefile. Other than that, what other reason? -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 11 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:16:11 +0000 Gerrit-HasComments: Yes
