Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/19776/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19776/11//COMMIT_MSG@28 PS11, Line 28: file_path, pos), s > nit: maybe "file_path, position"? Thanks, fixed to 'file_path'. The Iceberg spec states that position delete files must be sorted by (file_path, pos): https://iceberg.apache.org/spec/#position-delete-files It mentions predicate pushdown and optimized scanning. Btw, we are also planning to optimize the processing of position delete files: https://gerrit.cloudera.org/#/c/19850/ -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jun 2023 08:14:28 +0000 Gerrit-HasComments: Yes
