Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20025 )
Change subject: IMPALA-12193: Fix TSAN failures for DataCacheTest.SetReadOnly ...................................................................... Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/20025/1/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/20025/1/be/src/runtime/io/data-cache.cc@325 PS1, Line 325: // modifications. > The other threads in other functions get the lock in shared mode, so gettin Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/20025/1/be/src/runtime/io/data-cache.cc@329 PS1, Line 329: mean > Good point, we can skip the lock for revoking read only. Done http://gerrit.cloudera.org:8080/#/c/20025/3/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/20025/3/be/src/runtime/io/data-cache.cc@372 PS3, Line 372: RevokeReadOnly nit. maybe RevokeReadOnly() can be removed from the comment. http://gerrit.cloudera.org:8080/#/c/20025/3/be/src/runtime/io/data-cache.cc@374 PS3, Line 374: RevokeReadOnly nit. maybe RevokeReadOnly() can be removed from the comment. -- To view, visit http://gerrit.cloudera.org:8080/20025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc507f09b9c093a9034d601d8e7d37976bd0433e Gerrit-Change-Number: 20025 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 09 Jun 2023 23:46:52 +0000 Gerrit-HasComments: Yes
