Hello Riza Suminto, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20025
to look at the new patch set (#4).
Change subject: IMPALA-12193: Fix TSAN failures for DataCacheTest.SetReadOnly
......................................................................
IMPALA-12193: Fix TSAN failures for DataCacheTest.SetReadOnly
The DataCacheTest.SetReadOnly currently fails in TSAN
builds, because there is a data race on the DataCache::readonly_
variable. The set of the variable happens without obtaining a
lock, and that is an intentional choice to prevent new readers
before waiting for existing readers to finish. This changes the
DataCache::readonly_ variable and the DataCache::CacheFile::readonly_
variable to be AtomicBools.
Testing:
- DataCacheTest.SetReadOnly passes on a TSAN build.
Change-Id: Ibc507f09b9c093a9034d601d8e7d37976bd0433e
---
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
2 files changed, 30 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20025/4
--
To view, visit http://gerrit.cloudera.org:8080/20025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc507f09b9c093a9034d601d8e7d37976bd0433e
Gerrit-Change-Number: 20025
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
