Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20034
Change subject: IMPALA-12197: Prevent assertion failures when isClusteringColumn() is called on a IcebergTimeTravelTable. ...................................................................... IMPALA-12197: Prevent assertion failures when isClusteringColumn() is called on a IcebergTimeTravelTable. When using local catalog mode, if a runtime filter is being generated for a time travel iceberg table, then a query may fail with "ERROR: IllegalArgumentException: null" In the planner an Iceberg table that is being accessed with Time Travel is represented by an IcebergTimeTravelTable object. This object represents a time-based variation on a base table. The IcebergTimeTravelTable may represent a different schema from the base table, it does this by tracking its own set of Columns. As part of generating a runtime filter the isClusteringColumn() method is called on the table. IcebergTimeTravelTable was delegating this call to the base object. In local catalog mode this method is implemented by LocalTable which has a Preconditions check (an assertion) that the column parameter matches the stored column. In this case the check fails as the base table and time travel table have their own distinct set of column objects. The fix is to have IcebergTimeTravelTable provide its own isClusteringColumn() method. For iceberg there are no clustering columns so this method simply returns false. TESTING - Ran all end-to-end tests. - Added test case for query that failed. Change-Id: I51d04c8757fb48bd417248492d4615ac58085632 --- M fe/src/main/java/org/apache/impala/catalog/IcebergTimeTravelTable.java A testdata/workloads/functional-query/queries/QueryTest/iceberg-time-travel.test M tests/query_test/test_iceberg.py 3 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/20034/1 -- To view, visit http://gerrit.cloudera.org:8080/20034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I51d04c8757fb48bd417248492d4615ac58085632 Gerrit-Change-Number: 20034 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]>
