Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20034 )
Change subject: IMPALA-12197: Prevent assertion failures when isClusteringColumn() is called on a IcebergTimeTravelTable. ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/20034/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-time-travel.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-time-travel.test: http://gerrit.cloudera.org:8080/#/c/20034/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-time-travel.test@4 PS5, Line 4: drop table if exists iceberg_flights; : drop table if exists iceberg_airlines; nit: the test uses a unique database, so I don't think we need this. -- To view, visit http://gerrit.cloudera.org:8080/20034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51d04c8757fb48bd417248492d4615ac58085632 Gerrit-Change-Number: 20034 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 17:08:36 +0000 Gerrit-HasComments: Yes
