Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 )
Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases ...................................................................... Patch Set 5: Code-Review+2 (1 comment) LGTM. Since existing comments have been addressed, bumping to +2. Thanks Riza for the patch. http://gerrit.cloudera.org:8080/#/c/20009/5/testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q67.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q67.test: http://gerrit.cloudera.org:8080/#/c/20009/5/testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q67.test@512 PS5, Line 512: mem > This is because prior to this patch, each agg class is capped with inputCar Yes, each agg class in the merge phase of the agg is consuming corresponding per-class rows from the first phase. Additional discussion here: https://gerrit.cloudera.org/c/20009/4/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test#322 -- To view, visit http://gerrit.cloudera.org:8080/20009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d414fe56b027f887c7f901d8a6799a388b16b95 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 11 Jun 2023 23:33:31 +0000 Gerrit-HasComments: Yes
