Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 )
Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/20009/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20009/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@98 PS4, Line 98: the either of nit: either the input .. http://gerrit.cloudera.org:8080/#/c/20009/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@104 PS4, Line 104: content nit: 'contain' http://gerrit.cloudera.org:8080/#/c/20009/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@253 PS4, Line 253: unknownEstimate = true; If we get an unknown estimate for any one aggregate class, even though the final cardinality will be returned as -1, we are continuing the iteration. Is it to initialize the num groups for each class ? Otherwise we could break out of the loop. http://gerrit.cloudera.org:8080/#/c/20009/4/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test: http://gerrit.cloudera.org:8080/#/c/20009/4/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test@322 PS4, Line 322: 3373800 Could you clarify how this cost changed to 1/5th of the original cost ? There are 5 aggregation classes so effectively the aggregation is working proportionally more. Similar changes are there in a few other tests. -- To view, visit http://gerrit.cloudera.org:8080/20009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d414fe56b027f887c7f901d8a6799a388b16b95 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Jun 2023 01:48:16 +0000 Gerrit-HasComments: Yes
