Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20040 )
Change subject: IMPALA-12200: Cap stats NDV from SetOperationStmt.createMetadata ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20040/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/20040/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@185 PS3, Line 185: public Column getSourceColumn() { > The intention to return Column here is so that duplicate Column reference f You could handle de-duplication here if you pivoted the select items into a column vector in the caller. The logic as it is seems to ignore the context of the source column in the expression. One interesting case to test is union being used like partition table where many of the arms are provably false. Feel free to make the case further to leave as-is but this interface seems to limit options moving forward. http://gerrit.cloudera.org:8080/#/c/20040/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@195 PS3, Line 195: if (slotRef == null || !slotRef.hasDesc() || slotRef.getDesc() == this) { > sourceExprs_ is a List<Expr>, and an Expr is the very base class of all kin Done -- To view, visit http://gerrit.cloudera.org:8080/20040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bb2eff5005fdfb11adf31499214c63dd552c05 Gerrit-Change-Number: 20040 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 13 Jun 2023 20:47:09 +0000 Gerrit-HasComments: Yes
