Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20040 )
Change subject: IMPALA-12200: Cap stats NDV from SetOperationStmt.createMetadata ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20040/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/20040/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@217 PS4, Line 217: Preconditions.checkArgument(minNdv > 0); Ran core tests again last night and some test fail assertion here. Turns out, it is possible to have 0 NDV initially like in this test. select f2 from functional.emptytable union all select int_col from functional.alltypes -- To view, visit http://gerrit.cloudera.org:8080/20040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bb2eff5005fdfb11adf31499214c63dd552c05 Gerrit-Change-Number: 20040 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 14:44:42 +0000 Gerrit-HasComments: Yes
