Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20073 )
Change subject: PROTOTYPE: IMPALA-11961/IMPALA-12207: Add Redhat 9 / Ubuntu 22 support ...................................................................... Patch Set 2: (5 comments) Adding my own comments as mental notes http://gerrit.cloudera.org:8080/#/c/20073/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20073/2/bin/impala-config.sh@117 PS2, Line 117: export IMPALA_GPERFTOOLS_VERSION=2.8.1-p1 I might try going to gperftools 2.10 when I build a new toolchain, but this works fine for now. http://gerrit.cloudera.org:8080/#/c/20073/2/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/20073/2/docker/entrypoint.sh@111 PS2, Line 111: apt-get install -y sudo git python3 This needs more explanation. "python" as a package doesn't exist on Ubuntu 22, so maybe this needs to be conditional. http://gerrit.cloudera.org:8080/#/c/20073/2/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/20073/2/docker/test-with-docker.py@297 PS2, Line 297: self.timeout_minutes = 240 This is a temporary thing while I use the docker-based tests. This won't be in the final version. http://gerrit.cloudera.org:8080/#/c/20073/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/20073/2/tests/custom_cluster/test_client_ssl.py@253 PS2, Line 253: # Python >3.10 has deprecated ssl.PROTOCOL_TLS : # Temporary hack: skip the assert about deprecation for 3.10 or above. : # Note: This is the version that impala-shell uses, not the version pytests uses. : if not python3_10_version_re.search(result.stderr): This needs a follow-up JIRA. http://gerrit.cloudera.org:8080/#/c/20073/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/20073/2/tests/shell/test_shell_commandline.py@149 PS2, Line 149: # If using OpenSSL 3, the strict protocol talking to Hive isn't working : # yet (and can hang), so disable it. This needs a follow-up JIRA and a better comment here. -- To view, visit http://gerrit.cloudera.org:8080/20073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1fcdb2f8c635ecd6dc7a8a1db81f5f389c78b86 Gerrit-Change-Number: 20073 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 23:59:54 +0000 Gerrit-HasComments: Yes
