Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20073 )
Change subject: PROTOTYPE: IMPALA-11961/IMPALA-12207: Add Redhat 9 / Ubuntu 22 support ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20073/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20073/2/bin/impala-config.sh@117 PS2, Line 117: export IMPALA_GPERFTOOLS_VERSION=2.8.1-p1 > I might try going to gperftools 2.10 when I build a new toolchain, but this Switched to 2.10. http://gerrit.cloudera.org:8080/#/c/20073/2/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/20073/2/docker/entrypoint.sh@111 PS2, Line 111: apt-get install -y sudo git python3 > It seems like a reasonable time to move all container builds to python3. It's possible that this would work without a python install. In the container, we invoke bin/bootstrap_system.sh. I'm not sure that we need python before that. So, this code may change if I have some cycles. http://gerrit.cloudera.org:8080/#/c/20073/2/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/20073/2/docker/test-with-docker.py@297 PS2, Line 297: self.timeout_minutes = 240 > This is a temporary thing while I use the docker-based tests. This won't be Removed. http://gerrit.cloudera.org:8080/#/c/20073/2/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20073/2/shell/CMakeLists.txt@56 PS2, Line 56: add_custom_command(OUTPUT "${PYTHON3_VENV}" : COMMAND "$ENV{IMPALA_SYSTEM_PYTHON3}" -m venv "${PYTHON3_VENV}" > Ubuntu 22 uses python 3.10. (Redhat 9 doesn't have this problem, presumably I modified this to use impala-virtualenv for Python < 3.6 and use Python 3's venv module otherwise. That bypasses the Ubuntu 16.04 issue. If there are any problems, we can change the point where we make the switch (e.g. we can only apply it to Python >=3.10 if we want to). My main thought is that using Python 3's venv module for the Python 3 virtualenv seems more canonical, so I'm applying it more broadly. http://gerrit.cloudera.org:8080/#/c/20073/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/20073/2/tests/custom_cluster/test_client_ssl.py@253 PS2, Line 253: # Python >3.10 has deprecated ssl.PROTOCOL_TLS : # Temporary hack: skip the assert about deprecation for 3.10 or above. : # Note: This is the version that impala-shell uses, not the version pytests uses. : if not python3_10_version_re.search(result.stderr): > This needs a follow-up JIRA. Added JIRA. http://gerrit.cloudera.org:8080/#/c/20073/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/20073/2/tests/shell/test_shell_commandline.py@149 PS2, Line 149: # If using OpenSSL 3, the strict protocol talking to Hive isn't working : # yet (and can hang), so disable it. > This needs a follow-up JIRA and a better comment here. Removed this code, because the issue is not really related to OpenSSL. With the fix for IMPALA-12224, the tests no longer hang, so this doesn't skip any of them. The test failures can be addressed in a future change. -- To view, visit http://gerrit.cloudera.org:8080/20073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1fcdb2f8c635ecd6dc7a8a1db81f5f389c78b86 Gerrit-Change-Number: 20073 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 16 Jun 2023 23:59:09 +0000 Gerrit-HasComments: Yes
