Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: PROTOTYPE IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/19863/16/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/19863/16/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@2021 PS16, Line 2021: } catch (UnsupportedOperationException e) { > This exception is kind of concerning. I think it's an artifact of building This comes from a few lambdas stored as class members: UnsupportedOperationException: can't get field offset on a hidden class: private final java.io.FileDescriptor sun.nio.ch.NioSocketImpl$$Lambda$98/0x00000008012e4538.arg$1 UnsupportedOperationException: can't get field offset on a hidden class: private final org.apache.iceberg.DeleteFileIndex org.apache.iceberg.DeleteFileIndex$$Lambda$555/0x0000000801b93c78.arg$1 UnsupportedOperationException: can't get field offset on a hidden class: private final org.apache.iceberg.hadoop.SerializableConfiguration org.apache.iceberg.hadoop.HadoopFileIO$$Lambda$296/0x0000000801675a60.arg$1 These are outside our control. It's not clear there is a good workaround for handling them. This seems like the result of Java 15+ (https://github.com/doanduyhai/Achilles/issues/372) changing how lambda capture is implemented internally. A little underestimation shouldn't hurt. However jamm seems to be more active and claims Java 17 support. I'm going to try switching to it. -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 17:52:57 +0000 Gerrit-HasComments: Yes
