Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: PROTOTYPE IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19863/16/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/19863/16/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@2021 PS16, Line 2021: if (size > Integer.MAX_VALUE) { > Jamm's javaagent avoids this problem and allows removing all the add-opens Ok, doesn't seem to completely avoid it in Java 17. custom_cluster/test_local_catalog.py::TestLocalCatalogRetries::test_replan_limit specifically hits the NioSocketImpl case. -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 16 Jun 2023 17:12:11 +0000 Gerrit-HasComments: Yes
