ttttttz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in 
analytic limit pushdown
......................................................................


Patch Set 17:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1886
PS16, Line 1886:     // If a constant FALSE conjunct is found, we don't need to 
evaluate the other
> line too long (91 > 90)
Ack


http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906
PS16, Line 1906:     }
> line too long (91 > 90)
Ack



--
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:22:59 +0000
Gerrit-HasComments: Yes

Reply via email to